fix: dtype roundtrip guard#10
Merged
Merged
Conversation
Freeze the public contract so it can't change silently within a major version: - tests/contract/test_surface.py pins __all__ and the exact signature of every exported function. - tests/contract/test_behavior.py freezes documented round-trips, dtypes, errors, the length-prefixed header shape, and the token wire format via a frozen golden token (cross-version decode stability). - CONTRACT.md documents the SemVer promise and the append-only rule for tests/contract/.
Add --doctest-modules so the >>> examples in pl_row_encode's public docstrings execute under pytest. This makes the documented usage a third contract layer (alongside tests/contract/) and guarantees the examples stay runnable. All 6 module doctests pass with no repr brittleness.
Replace the categorical-only denylist with an allowlist-based classifier: known-good dtypes encode silently, Categorical is hard-rejected, and any unvetted dtype emits a UserWarning that it may fail or panic on decode. This keeps the encodable-implies-decodable invariant general without maintaining an exhaustive denylist, while never running the dangerous decode probe on an unknown type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more code to check if a dtype can roundtrip