feat: human-readable acceptance criteria across CLI, dashboard, and prompts#84
Merged
Merged
Conversation
…rompts Add a pure formatter that splits run-on acceptance-criteria blobs into discrete, human-readable items so a person clicking through a story can read the intent rather than parsing a wall of text. - internal/criteria/format.go: Format/FormatMarkdown — sentence-splitting that guards abbreviations (e.g.) and identifier periods (WorldState.copy()) and strips -, *, bullet, and ordinal markers. Fully unit-tested. - nxd review <story>: prints a Description block + bulleted Acceptance Criteria block (previously showed neither). - web snapshot: exposes acceptance_criteria_items (story_id -> []string); dashboard expands a detail row with description + criteria checklist when a story title is clicked (storyDetailRow/toggleStoryDetail). - Tech-Lead prompt + planner tool schema: require 3-6 intent-first criteria, one per line, so newly planned stories are readable at the source. TDD: tests written first for the formatter, review command, and snapshot. Full suite green (go test ./... -race), go vet clean, golangci-lint 0 issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acceptance criteria authored as a single run-on technical blob (
go test green. WorldState.copy() ...) were unreadable to a human clicking through a story. This adds a pure formatter and wires it into every surface where a person reads criteria.Changes
internal/criteria/format.go— pure (no-I/O)Format(raw) []string+FormatMarkdown(raw) string. Sentence-splitting that guards abbreviations (e.g.) and identifier periods (WorldState.copy()), and strips-/*/•/ordinal markers. 14 table-driven test cases pin the segmentation rules.nxd review <story>— now prints aDescription:block and a bulletedAcceptance Criteria:block (previously showed neither).acceptance_criteria_items(story_id → []string); clicking a story title expands a detail row with the description + criteria checklist (storyDetailRow/toggleStoryDetail).prompts.go) and planner tool schema (planner_tools.go) require 3-6 discrete, intent-first criteria, one per line, so newly planned stories are readable at the source.Testing
TDD throughout (tests written first → fail → implement → pass).
go test ./... -race -count=1— all 30 packages passgo vet ./...— cleangolangci-lint run— 0 issuesgo build -o /tmp/nxd ./cmd/nxd/— clean