feat(orchestrator): add pipeline self-declaration#404
Draft
JamyDev wants to merge 2 commits into
Draft
Conversation
Pass engine-produced values (TopicRegistry, TopicKey, ConsumerGroup) to Stage.New and Stage.DLQ via StageContext. Controllers need the registry for publishing to downstream stages and the topic key/group for their own identity — these are engine-owned, not host-provided Deps. DLQ StageContext automatically derives the DLQ topic key (appending "_dlq") and consumer group (appending "-dlq") from the primary stage's values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduce `submitqueue/orchestrator/pipeline.go` with three exports: - `Deps` struct: the full set of dependencies (logger, scope, storage, counter, and four extension factories) the orchestrator pipeline needs. This struct IS the service's public API toward deployers. - `Stages` slice: the complete 12-stage pipeline topology as a typed table of `pipeline.Stage[Deps]`. Each row declares a primary controller constructor and its DLQ reconciler. Adding a stage = adding one row. - `PublishOnlyTopics`: topics the orchestrator publishes to but does not consume (log, merge-conflict-check, runway-merge). - `Controllers` struct + `NewControllers`: RPC-facing controllers (currently Ping), NOT bound to any wire contract. Pure addition alongside the existing main.go wiring — no behavioral changes. Ref: doc/rfc/submitqueue/modular-queue-wiring.md (Step 3) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JamyDev
changed the title
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submitqueue/orchestrator/pipeline.gowith the orchestrator's self-declarationDepsstruct: logger, scope, storage, counter, and four extension factories — the service's public API toward deployersStages: all 12 pipeline stages as a[]pipeline.Stage[Deps]typed table, each with primary controller + DLQ reconcilerPublishOnlyTopics: log, merge-conflict-check, runway-mergeControllersstruct +NewControllers: RPC controllers (Ping), not bound to any wire contractStep 3 of the Modular Queue Wiring RFC. Stacked on #403.
Test plan
bazel build //submitqueue/orchestrator:go_default_librarycompilesmake gazelle— BUILD.bazel in syncmake fmt— code formattedVerification
aifx validateoutput🤖 Generated by minion
Co-Authored-By: minion-bot noreply@minion.uber.com
Co-Authored-By: jamy@uber.com
Agent: claude-code | Task: 6e2991d8-faa8-46c9-b94a-42ec9dcf242c
View your task: https://minion.uberinternal.com/task/6e2991d8-faa8-46c9-b94a-42ec9dcf242c
Test Plan
Issues
Stack