fix(controller): drop redundant ControllerName prefix from wrapped error messages#420
Merged
Merged
Conversation
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 21, 2026 22:27
This was referenced Jul 21, 2026
behinddwalls
approved these changes
Jul 21, 2026
roychying
force-pushed
the
chenghan.ying/stovepipe-buildsignal-controller
branch
from
July 22, 2026 01:03
be3d253 to
133ea41
Compare
behinddwalls
force-pushed
the
chenghan.ying/stovepipe-buildsignal-controller
branch
from
July 22, 2026 01:03
133ea41 to
33d360c
Compare
Collaborator
|
This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution. To fix manually: git fetch origin
git checkout chenghan.ying/remove-redundant-marker-in-log
git rebase --onto origin/chenghan.ying/stovepipe-buildsignal-controller 133ea412b98791a3e3c8759d5de77d6c7d130a8b chenghan.ying/remove-redundant-marker-in-log
# resolve conflicts, then:
git push --force-with-leaseThen update this PR's base branch: gh pr edit 420 --base chenghan.ying/stovepipe-buildsignal-controller |
roychying
force-pushed
the
chenghan.ying/remove-redundant-marker-in-log
branch
from
July 22, 2026 01:09
7cdb613 to
b06e06a
Compare
behinddwalls
force-pushed
the
chenghan.ying/stovepipe-buildsignal-controller
branch
from
July 22, 2026 01:12
33d360c to
f3b7e20
Compare
Collaborator
|
This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution. To fix manually: git fetch origin
git checkout chenghan.ying/remove-redundant-marker-in-log
git rebase --onto origin/chenghan.ying/stovepipe-buildsignal-controller 33d360c44b86c128cfeb74206179dc810f5e1afa chenghan.ying/remove-redundant-marker-in-log
# resolve conflicts, then:
git push --force-with-leaseThen update this PR's base branch: gh pr edit 420 --base chenghan.ying/stovepipe-buildsignal-controller |
roychying
force-pushed
the
chenghan.ying/stovepipe-buildsignal-controller
branch
2 times, most recently
from
July 22, 2026 01:16
bf69d95 to
d187bbc
Compare
roychying
force-pushed
the
chenghan.ying/remove-redundant-marker-in-log
branch
from
July 22, 2026 01:17
b06e06a to
807bfd9
Compare
behinddwalls
changed the base branch from
chenghan.ying/stovepipe-buildsignal-controller
to
main
July 22, 2026 01:25
behinddwalls
force-pushed
the
chenghan.ying/remove-redundant-marker-in-log
branch
from
July 22, 2026 01:25
807bfd9 to
c8186f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant controllerName prefix in error msg body