feat(errs): share cross-domain error identities#421
Closed
albertywu wants to merge 1 commit into
Closed
Conversation
albertywu
marked this pull request as ready for review
July 22, 2026 00:06
albertywu
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 22, 2026 00:06
albertywu
force-pushed
the
wua/platform-error-classification-rfc
branch
from
July 22, 2026 03:55
e18feec to
e39b834
Compare
albertywu
force-pushed
the
wua/platform-version-mismatch-retry
branch
from
July 22, 2026 03:55
e93d3a1 to
26cf446
Compare
Summary: Define ErrNotFound and ErrVersionMismatch in platform/errs for conditions with stable semantics across domains. Migrate SubmitQueue and Stovepipe storage and queue configuration code to use the platform errors directly, and keep only ErrVersionMismatch automatically classified as retryable. Test Plan: - make fmt - make build - make test - make lint - make check-tidy - make check-gazelle Revert Plan: Revert this commit. API Changes: Remove domain ErrNotFound and ErrVersionMismatch sentinels plus storage IsNotFound and WrapNotFound helpers. Callers use platform/errs directly. Monitoring and Alerts: N/A
albertywu
force-pushed
the
wua/platform-version-mismatch-retry
branch
from
July 22, 2026 04:33
26cf446 to
95c0783
Compare
albertywu
force-pushed
the
wua/platform-error-classification-rfc
branch
from
July 22, 2026 04:33
e39b834 to
ef3e591
Compare
albertywu
changed the title
Contributor
Author
|
After exploring a bit I'm coming back in favor of status quo -- classifying errors as retry-able in the controller logic itself vs relying on platform alternatives and duplicating classifiers across services. Closing out these PRs, don't think it's necessary. Status quo pattern: storage / extension layers return domain-specific errors, and controller logic classifies as retry-able when returning errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Define ErrNotFound and ErrVersionMismatch in platform/errs for conditions with stable semantics across domains. Migrate SubmitQueue and Stovepipe storage and queue configuration code to use the platform errors directly, and keep only ErrVersionMismatch automatically classified as retryable.
Test Plan
Revert Plan
Revert this commit.
API Changes
Remove domain ErrNotFound and ErrVersionMismatch sentinels plus storage IsNotFound and WrapNotFound helpers. Callers use platform/errs directly.
Monitoring and Alerts
N/A
Issues
Stack