migrate controller to core/errors TangoError by justinwon777 · Pull Request #173 · uber/tango

justinwon777 · 2026-07-10T08:46:10Z

This removes all usages of core/common errors in controller and classifies user failures with TangoError.
GetChangedTargets and GetTargetGraph return error with mapper.ToProtoError(retErr) so all errors are classified.

Test Plan

unit tests

No functional changes; goimports reorders tangopb/tango.pb.go's import grouping. gazelle and gofmt reported nothing to change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Add a mapper package to convert core/errors.TangoError into the proto TangoError message returned by RPCs.

justinwon777 requested review from a team as code owners July 10, 2026 08:46

justinwon777 marked this pull request as draft July 10, 2026 08:49

justinwon777 changed the title ~~[WIP] refactor: migrate controller and orchestrator to core/errors TangoError~~ [WIP] migrate controller and orchestrator to core/errors TangoError Jul 10, 2026

justinwon777 force-pushed the common-migrate branch from 522bb2a to 1b8149a Compare July 11, 2026 05:41

justinwon777 changed the title ~~[WIP] migrate controller and orchestrator to core/errors TangoError~~ [WIP] migrate controller to core/errors TangoError Jul 11, 2026

justinwon777 force-pushed the common-migrate branch from 1b8149a to 57dcd8d Compare July 11, 2026 05:57

justinwon777 force-pushed the justin.won/errors branch from 3cb087d to 07400ac Compare July 11, 2026 18:38

justinwon777 force-pushed the common-migrate branch from 57dcd8d to 9844525 Compare July 11, 2026 18:39

justinwon777 force-pushed the justin.won/errors branch from 07400ac to 4af25b1 Compare July 13, 2026 06:26

justinwon777 changed the title ~~[WIP] migrate controller to core/errors TangoError~~ migrate controller to core/errors TangoError Jul 13, 2026

justinwon777 marked this pull request as ready for review July 13, 2026 17:36

justinwon777 force-pushed the justin.won/errors branch from 4af25b1 to e75b330 Compare July 13, 2026 18:01

justinwon777 force-pushed the common-migrate branch from 9844525 to 49e0fa3 Compare July 13, 2026 19:06

justinwon777 force-pushed the justin.won/errors branch from e75b330 to 9f4720b Compare July 13, 2026 23:49

justinwon777 force-pushed the common-migrate branch from 49e0fa3 to b03d6d8 Compare July 13, 2026 23:56

justinwon777 force-pushed the justin.won/errors branch 3 times, most recently from a30bd54 to 1a48b38 Compare July 14, 2026 19:20

justinwon777 marked this pull request as draft July 15, 2026 01:29

justinwon777 force-pushed the justin.won/errors branch 3 times, most recently from 4149fe6 to 331adab Compare July 15, 2026 23:29

Base automatically changed from justin.won/errors to main July 16, 2026 08:22

justinwon777 force-pushed the common-migrate branch 4 times, most recently from 6ef5b89 to 09379b9 Compare July 16, 2026 09:15

justinwon777 marked this pull request as ready for review July 16, 2026 09:19

justinwon777 force-pushed the common-migrate branch from 09379b9 to 97b10da Compare July 16, 2026 09:27