refactor: migrate callsites to entity types and consolidate config#212
Draft
yushan8 wants to merge 1 commit into
Draft
refactor: migrate callsites to entity types and consolidate config#212yushan8 wants to merge 1 commit into
yushan8 wants to merge 1 commit into
Conversation
yushan8
marked this pull request as draft
July 17, 2026 04:11
3 tasks
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 17, 2026 05:13
9bd4bdf to
d05117c
Compare
yushan8
force-pushed
the
yushan/migrate-callsites
branch
from
July 17, 2026 05:13
94857f0 to
042586a
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 17, 2026 16:10
d05117c to
7025afd
Compare
yushan8
force-pushed
the
yushan/migrate-callsites
branch
from
July 17, 2026 16:10
042586a to
c367538
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 17, 2026 17:08
7025afd to
ecb2996
Compare
yushan8
force-pushed
the
yushan/migrate-callsites
branch
from
July 17, 2026 17:08
c367538 to
24ef6fd
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 17, 2026 22:57
ecb2996 to
36f3f33
Compare
yushan8
force-pushed
the
yushan/migrate-callsites
branch
2 times, most recently
from
July 17, 2026 23:07
36f5b20 to
89506ef
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 17, 2026 23:07
36f3f33 to
91d9a76
Compare
yushan8
force-pushed
the
yushan/migrate-callsites
branch
from
July 17, 2026 23:32
89506ef to
194fded
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 17, 2026 23:32
91d9a76 to
9e0abdd
Compare
- Orchestrator interface returns *mapper.GraphChunkReader instead of
storage.GraphReader, removing proto leakage from the orchestrator layer
- Controller uses mapper.GraphChunkToProto at send time, streaming
entity.GraphChunk internally
- Controller changed-targets path uses streaming.SplitBySize and
streaming.SplitMetadata for chunking
- Consolidate service.streaming.{max_num_targets,...} into single
service.max_message_bytes (DefaultMaxMessageBytes = 4,250,000)
- Remove old chunking code from core/common (ResultToGetTargetGraphResponse,
ChunkMetadata, chunkTargets, splitMap, and associated constants)
- Update query-bench to use mapper.ResultToGraphChunks
- Regenerate orchestrator mock for new return type
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yushan8
force-pushed
the
yushan/migrate-callsites
branch
from
July 18, 2026 00:23
194fded to
cb43482
Compare
yushan8
force-pushed
the
yushan/streaming-and-mappers
branch
from
July 18, 2026 00:23
9e0abdd to
b621c93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*mapper.GraphChunkReaderinstead ofstorage.GraphReader, removing proto leakage from the orchestrator layerentity.GraphChunkinternally, converting to proto viamapper.GraphChunkToProtoonly at send timestreaming.SplitBySizeandstreaming.SplitMetadatafor chunkingservice.streaming.{max_num_targets,...}into a singleservice.max_message_bytesfield (DefaultMaxMessageBytes = 4,250,000)core/common(ResultToGetTargetGraphResponse,ChunkMetadata,chunkTargets,splitMap, and associated constants/tests)query-benchto usemapper.ResultToGraphChunksStack
Test plan
make buildpassesmake test— all 19 test targets passmake gazelle— BUILD files in syncnewGraphChunkReaderFromProtohelperGraphChunkReaderreturn type