feat(observability/metrics): add Emitter and Begin/Complete lifecycle helpers#214
Open
xytan0056 wants to merge 1 commit into
Open
feat(observability/metrics): add Emitter and Begin/Complete lifecycle helpers#214xytan0056 wants to merge 1 commit into
xytan0056 wants to merge 1 commit into
Conversation
xytan0056
changed the title
xytan0056
changed the title
xytan0056
force-pushed
the
pr1-emitter-core
branch
from
July 17, 2026 17:15
72fb35c to
826487e
Compare
xytan0056
changed the title
xytan0056
changed the title
… helpers Introduces the observability/metrics package per docs/observability/metrics.md: a thin, concrete wrapper over tally.Scope pinning the path shape <scope>.<op>.<name>. - emitter.go: Emitter (New/Nop/Tagged/Counter/DurationHistogram/ ValueHistogram) plus the Begin/Complete lifecycle helpers over an Op handle - names.go: shared op/tag-key/result-value constants and Outcome(err) (context.Canceled -> cancelled; DeadlineExceeded -> failure) - emitter_test.go: path-shape, tag isolation/composition, Begin/Complete result tagging, and Outcome classification
xytan0056
force-pushed
the
pr1-emitter-core
branch
from
July 17, 2026 23:10
826487e to
fb00357
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
observability/metricspackage per the merged design doc (docs/observability/metrics.md, #158): a thin, concrete wrapper overtally.Scopepinning the path shape<scope>.<op>.<name>.emitter.go—Emitter(New/Nop/Tagged/Counter/DurationHistogram/ValueHistogram) plus theBegin/Completelifecycle helpers over anOphandle.names.go— shared op / tag-key / result-value constants andOutcome(err)(onlycontext.Canceled→ cancelled;DeadlineExceeded→ failure, a genuine timeout).Test plan
CI