refactor(graphrunner): route metrics through observability/metrics Emitter#217
Open
xytan0056 wants to merge 1 commit into
Open
refactor(graphrunner): route metrics through observability/metrics Emitter#217xytan0056 wants to merge 1 commit into
xytan0056 wants to merge 1 commit into
Conversation
xytan0056
force-pushed
the
pr3-orchestrator-metrics
branch
from
July 17, 2026 21:22
d203b30 to
28b8209
Compare
xytan0056
force-pushed
the
pr4-graphrunner-metrics
branch
from
July 17, 2026 21:22
2a9c525 to
7baf10f
Compare
xytan0056
force-pushed
the
pr3-orchestrator-metrics
branch
from
July 17, 2026 21:41
28b8209 to
3b9c7e9
Compare
xytan0056
force-pushed
the
pr4-graphrunner-metrics
branch
3 times, most recently
from
July 17, 2026 21:46
14bc8a6 to
098f66b
Compare
xytan0056
force-pushed
the
pr3-orchestrator-metrics
branch
from
July 17, 2026 21:47
3b9c7e9 to
97b3839
Compare
xytan0056
force-pushed
the
pr4-graphrunner-metrics
branch
from
July 17, 2026 21:47
098f66b to
1f78e24
Compare
xytan0056
changed the title
…itter Port the native graph runner off raw tally.Scope to the emitter. - Params keeps Scope tally.Scope; the runner subscopes to graph_runner and builds its own emitter, emitting under op compute (snake of GraphRunner.Compute). - Three phase Timers -> DurationHistogram (bazel_query/git_file_hashes/ target_hash_duration); target_count Gauge -> ValueHistogram. - Op const + buckets live in graphrunner/metrics.go.
xytan0056
force-pushed
the
pr3-orchestrator-metrics
branch
from
July 17, 2026 23:10
97b3839 to
57d3c09
Compare
xytan0056
force-pushed
the
pr4-graphrunner-metrics
branch
from
July 17, 2026 23:10
1f78e24 to
6938065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the native graph runner off raw
tally.Scopeto*metrics.Emitter.ParamskeepsScope tally.Scope; the runner builds its own emitter and emits under opgraph_runner(nested beneath the orchestrator scope it's handed).Timers →DurationHistogram(bazel_query_duration,git_file_hashes_duration,target_hash_duration);target_countGauge→ValueHistogram.graphrunner/metrics.go.core/bazelintentionally left uninstrumented — the query is already timed here.