Skip to content
This repository was archived by the owner on Jan 22, 2022. It is now read-only.

update addressbar.text via timer#365

Open
balcy wants to merge 3 commits into
xenialfrom
xenial_-_addressbartext
Open

update addressbar.text via timer#365
balcy wants to merge 3 commits into
xenialfrom
xenial_-_addressbartext

Conversation

@balcy

@balcy balcy commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

fixes #299

@balcy balcy marked this pull request as ready for review September 20, 2020 17:13
Comment thread src/app/webbrowser/AddressBar.qml Outdated

@UniversalSuperBox UniversalSuperBox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this another try today -- right now, the search results from the last text entry pause stay up until the next pause. Might it be better for the results to go away immediately when the user starts typing with the delay to perform the search kept?

@UniversalSuperBox UniversalSuperBox force-pushed the xenial_-_addressbartext branch from 22e9950 to b4a607e Compare May 14, 2021 18:59
@lduboeuf

lduboeuf commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

hi, any news ?

@UniversalSuperBox

Copy link
Copy Markdown
Member

#299 (comment)

It's unclear who experiences this issue, and those who do have not verified that this fixes it.

@lduboeuf

lduboeuf commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

will give a try, i thought it was solving the issue at Morph or webapp startup where the address field focus is stealed by the webpage

@balcy

balcy commented Dec 4, 2021

Copy link
Copy Markdown
Collaborator Author

at that time it was possible for me to reproduce the issue:

  • the phone should have a very long browser history (e.g. not cleared for a long time)
  • for each keypress in the address bar there is a small delay, because the history is searched for suggestions (previously visited pages)
  • with the fix you can type in the address bar without the delay

in my opinion it cannot have any effect no webapps, because they use another address bar (where you cannot type), and is not related to keyboar focus / startup problems, but only the typing in the address bar text field. (see linked issue 299)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL input fields becomes unresponsive while searching hints

3 participants