Add cost tracking for blanket billing with karpenter#73
Draft
jawadqur wants to merge 25 commits into
Draft
Conversation
jawadqur
marked this pull request as ready for review
November 1, 2023 16:29
… into feat/karpenter-for-cost
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Contributor
|
restoring the branch for evaluation of countinue working on this |
mfshao
marked this pull request as draft
April 28, 2025 21:57
| return nil, err | ||
| } | ||
|
|
||
| if payModel.Local && Config.Config.Karpenter && strings.Contains(strings.ToLower(payModel.Name), "trial") { |
Contributor
There was a problem hiding this comment.
Is this correct? Only "Trial Workspaces" will have cost usage reports and any "Direct Pay" workspaces will not have cost usage reports?
Test/updates to cost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket: BRH-581
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes