Skip to content

PR 6: refactor: per-area small refactors (CTS, Scheduler, Students, CMS) #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlorenzo wants to merge 6 commits into
base: main
Choose a base branch
from
Open

PR 6: refactor: per-area small refactors (CTS, Scheduler, Students, CMS) #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1453d60
refactor(cts): collapse hardcoded CourseStudents rows into a v-for
rlorenzo Jun 10, 2026
e92e08d
refactor(scheduler): share schedule filter LINQ via IScheduleEntity
rlorenzo Jun 10, 2026
241fb3c
refactor(students): consolidate StudentGroupService photo + Ross helpers
rlorenzo Jun 10, 2026
83489ac
refactor(cms): reduce Codecs to UU-only and cover with tests
rlorenzo Jun 10, 2026
1cc3003
fix(students): avoid cross-context join in course Ross gallery
rlorenzo Jun 10, 2026
829c1dd
test(students): await SaveChangesAsync in include-Ross course test
rlorenzo Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 18 additions & 73 deletions VueApp/src/CTS/pages/CourseStudents.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
<script setup lang="ts">
import { ref } from "vue"

const student = ref("")

// Mock data for prototype; real implementation will replace with API data.
const loggedInStudents = [
{ id: 23631, name: "Montserrat Armero", time: "10/16/24 2:29:01 PM" },
{ id: 34123, name: "Hailey Atwood", time: "10/16/24 2:29:01 PM" },
{ id: 34158, name: "Xander Avila", time: "10/16/24 2:29:01 PM" },
]
</script>
<template>
<h1>Students for VET430 Lab 1 Challenging Communication - Simulated Lab with Actors and Video</h1>
Expand All @@ -9,12 +17,12 @@ const student = ref("")
<div class="row q-mb-md">
<div class="col-12 col-md-6 col-lg-4">
<q-select
v-model="student"
dense
options-dense
outlined
label="Student"
:options="['Student 1', 'Student 2']"
v-model="student"
></q-select>
</div>
</div>
Expand All @@ -37,86 +45,23 @@ const student = ref("")
</tr>
</thead>
<tbody>
<tr>
<td class="text-center">
<q-btn
dense
flat
icon="assignment"
size="sm"
color="primary"
aria-label="Assess competency for Montserrat Armero"
to="AssessmentCompetency?studentId=23631&sessionId="
></q-btn>
</td>
<td>Montserrat Armero</td>
<td>10/16/24 2:29:01 PM</td>
<td class="text-center">
<q-icon
name="check"
color="primary"
size="sm"
aria-label="Manually added"
></q-icon>
</td>
<td class="text-center">
<q-btn
dense
icon="delete"
color="negative"
flat
size="sm"
aria-label="Remove Montserrat Armero"
></q-btn>
</td>
</tr>
<tr>
<td class="text-center">
<q-btn
dense
flat
icon="assignment"
size="sm"
color="primary"
aria-label="Assess competency for Hailey Atwood"
to="AssessmentCompetency?studentId=34123&sessionId="
></q-btn>
</td>
<td>Hailey Atwood</td>
<td>10/16/24 2:29:01 PM</td>
<td class="text-center">
<q-icon
name="check"
color="primary"
size="sm"
aria-label="Manually added"
></q-icon>
</td>
<td class="text-center">
<q-btn
dense
icon="delete"
color="negative"
flat
size="sm"
aria-label="Remove Hailey Atwood"
></q-btn>
</td>
</tr>
<tr>
<tr
v-for="row in loggedInStudents"
:key="row.id"
>
<td class="text-center">
<q-btn
dense
flat
icon="assignment"
size="sm"
color="primary"
aria-label="Assess competency for Xander Avila"
to="AssessmentCompetency?studentId=34158&sessionId="
:aria-label="`Assess competency for ${row.name}`"
:to="`AssessmentCompetency?studentId=${row.id}&sessionId=`"
></q-btn>
</td>
<td>Xander Avila</td>
<td>10/16/24 2:29:01 PM</td>
<td>{{ row.name }}</td>
<td>{{ row.time }}</td>
<td class="text-center">
<q-icon
name="check"
Expand All @@ -132,7 +77,7 @@ const student = ref("")
color="negative"
flat
size="sm"
aria-label="Remove Xander Avila"
:aria-label="`Remove ${row.name}`"
></q-btn>
</td>
</tr>
Expand Down
160 changes: 160 additions & 0 deletions test/CMS/CodecsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
using System.Text;
using Viper.Areas.CMS.Data;

namespace Viper.test.CMS;

// Guards the UU encoder/decoder in Viper.Areas.CMS.Data.Codecs, which replicates
// ColdFusion's default "UU" encrypt()/decrypt() encoding. Round-trips prove encode
// and decode stay mutually consistent; the canonical-vector tests pin the uuencode
// wire format itself (the format legacy CF emits).
// UUEncode is retained for CMS-migration key-storage interop: new files must store
// their AES data key UU-encoded so the legacy CF system can still decrypt them during
// the parallel-run period (see PLAN-CMS.md s12.6), so it is exercised here too.
// Slated to move with Codecs into a dedicated CMS project.
public class CodecsTests
{
private static byte[] RunCodec(Action<Stream, Stream> codec, byte[] input)
{
using var inStream = new MemoryStream(input, writable: false);
using var outStream = new MemoryStream();
codec(inStream, outStream);
return outStream.ToArray();
}

// Deterministic, non-trivial byte pattern so failures are reproducible.
private static byte[] MakeData(int length)
{
var data = new byte[length];
for (int i = 0; i < length; i++)
data[i] = (byte)((i * 31 + 7) & 0xFF);
return data;
}

#region Round-trip Tests

// Lengths bracket the 45-byte line boundary and every encode tail branch
// (full 3-byte groups, 2-byte remainder, 1-byte remainder, empty).
[Theory]
[InlineData(0)]
[InlineData(1)]
[InlineData(2)]
[InlineData(3)]
[InlineData(4)]
[InlineData(5)]
[InlineData(44)]
[InlineData(45)]
[InlineData(46)]
[InlineData(47)]
[InlineData(48)]
[InlineData(89)]
[InlineData(90)]
[InlineData(91)]
[InlineData(135)]
[InlineData(1000)]
public void UUEncode_ThenUUDecode_ReturnsOriginal(int length)
{
var data = MakeData(length);
var roundTripped = RunCodec(Codecs.UUDecode, RunCodec(Codecs.UUEncode, data));
Assert.Equal(data, roundTripped);
}

[Fact]
public void UUEncode_ThenUUDecode_IsBinarySafeAcrossAllByteValues()
{
var data = new byte[256];
for (int i = 0; i < 256; i++)
data[i] = (byte)i;

var roundTripped = RunCodec(Codecs.UUDecode, RunCodec(Codecs.UUEncode, data));
Assert.Equal(data, roundTripped);
}

#endregion

#region Wire-format Tests

// "Cat" is the canonical uuencode example: a single data line whose first
// byte is the length char '#' (3) followed by "0V%T". Pins the format
// independently of the decoder, so a compensating encode+decode change
// can't hide behind the round-trip tests.
[Fact]
public void UUEncode_KnownInput_ProducesCanonicalUuencodedLine()
{
var encoded = Encoding.ASCII.GetString(RunCodec(Codecs.UUEncode, Encoding.ASCII.GetBytes("Cat")));
Assert.Equal("#0V%T", encoded.TrimEnd('\r', '\n'));
}

[Fact]
public void UUDecode_CanonicalUuencodedLine_ProducesOriginalBytes()
{
var decoded = RunCodec(Codecs.UUDecode, Encoding.ASCII.GetBytes("#0V%T\r\n"));
Assert.Equal("Cat", Encoding.ASCII.GetString(decoded));
}

#endregion

#region Empty-input Tests

[Fact]
public void UUEncode_EmptyInput_WritesNothing() => Assert.Empty(RunCodec(Codecs.UUEncode, []));

[Fact]
public void UUDecode_EmptyInput_WritesNothing() => Assert.Empty(RunCodec(Codecs.UUDecode, []));

#endregion

#region Null-argument Tests

[Fact]
public void UUEncode_NullInput_ThrowsArgumentNullException()
{
using var output = new MemoryStream();
var ex = Assert.Throws<ArgumentNullException>(() => Codecs.UUEncode(null!, output));
Assert.Equal("input", ex.ParamName);
}

[Fact]
public void UUEncode_NullOutput_ThrowsArgumentNullException()
{
using var input = new MemoryStream([1, 2, 3]);
var ex = Assert.Throws<ArgumentNullException>(() => Codecs.UUEncode(input, null!));
Assert.Equal("output", ex.ParamName);
}

[Fact]
public void UUDecode_NullInput_ThrowsArgumentNullException()
{
using var output = new MemoryStream();
var ex = Assert.Throws<ArgumentNullException>(() => Codecs.UUDecode(null!, output));
Assert.Equal("input", ex.ParamName);
}

[Fact]
public void UUDecode_NullOutput_ThrowsArgumentNullException()
{
using var input = new MemoryStream([1, 2, 3]);
var ex = Assert.Throws<ArgumentNullException>(() => Codecs.UUDecode(input, null!));
Assert.Equal("output", ex.ParamName);
}

[Fact]
public void UUDecode_OutOfRangeByte_ThrowsFormatException()
{
// A non-ASCII byte (>= 128) cannot index the 128-entry decode table; malformed
// input must surface as a controlled FormatException, not IndexOutOfRangeException.
using var input = new MemoryStream([0xFF]);
using var output = new MemoryStream();
Assert.Throws<FormatException>(() => Codecs.UUDecode(input, output));
}

[Fact]
public void UUDecode_TruncatedLine_ThrowsFormatException()
{
// Line header claims three octets but the encoded quartet is cut short (EOF mid-read).
using var input = new MemoryStream(Encoding.ASCII.GetBytes("#0V"));
using var output = new MemoryStream();
Assert.Throws<FormatException>(() => Codecs.UUDecode(input, output));
}

#endregion
}
Loading
Loading