CodeQL 16: refactor: drop redundant casts on null and ViewBag

[rlorenzo]

Summary

Closes 2 of the cs/useless-upcast alerts in production code by dropping unnecessary type casts:

• VerificationService.cs:236: (DateTime?)null becomes default(DateTime?). Same value, same inferred field type, no cast.
• _EmailLayout.cshtml:41-50: extracted var baseUrl = ViewBag.BaseUrl as string; into a Razor block. The (string?) and (string) casts at the two use sites collapse into the single as string coercion at the top.

What was dropped from earlier draft

This branch supersedes #202 (now closed):

• Two duplicate test-file commits (catch-narrowing): those are already shipping in CodeQL 15: chore(tests): narrow catch(Exception) to specific types in test helpers #207.
• CliniciansController.cs:204: the prior draft changed role = (string?)null to role = default(string) inside an anonymous type. Under <Nullable>enable</Nullable>, default(string) is null typed as non-nullable string (CS8625), and would change the inferred field type. Reverted. Kept as (string?)null because the cast is conveying nullability intent, not a useless upcast.
• PhotoExportService.cs PhotoLookupResult record extraction: the CodeQL 16: refactor: remove useless upcasts via record types and default(T) #202 description mentioned this, but it was never actually committed to the branch. Not included here either; can be done in a follow-up if desired.

Context

Sixteenth in the CodeQL N: cleanup series.

Test plan

• npm run test:backend: passing (pre-commit hooks ran lint+test+verify on the commit)
• Pre-commit lint+test+verify all passed

[codecov-commenter]

Bundle Report

Bundle size has no change ✅

[codecov-commenter]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.02%. Comparing base (f45f6b7) to head (c49fa2c).

Files with missing lines	Patch %	Lines
...eb/EmailTemplates/Views/Shared/_EmailLayout.cshtml	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   43.02%   43.02%           
=======================================
  Files         881      881           
  Lines       51436    51437    +1     
  Branches     4812     4812           
=======================================
+ Hits        22131    22132    +1     
  Misses      28779    28779           
  Partials      526      526           

Flag	Coverage Δ
backend	43.10% <66.66%> (+<0.01%)	⬆️
frontend	41.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rlorenzo]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

Audit log syntax normalized from explicit null cast to default(DateTime?). Email template header image URL logic refactored to extract ViewBag.BaseUrl into a local variable for cleaner conditional rendering.

Changes

Code quality improvements

Layer / File(s)	Summary
Audit log null syntax normalization web/Areas/Effort/Services/VerificationService.cs	EffortVerified audit value changed from (DateTime?)null to default(DateTime?) for consistency.
Email layout URL variable extraction web/EmailTemplates/Views/Shared/_EmailLayout.cshtml	ViewBag.BaseUrl extracted into a local baseUrl variable for the header image conditional logic, improving readability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• bsedwards

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: removing redundant casts on null literals and ViewBag type conversions across two files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The description clearly details the changes made: removing redundant casts in VerificationService.cs and _EmailLayout.cshtml, with context about what was excluded from earlier drafts and test results.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codeql/16-remove-redundant-casts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rlorenzo]

@bsedwards Low risk refactoring to drop unnecessary type casts. Merged to TEST.