141 lost license in workflow edit

[amadulhaxxani]

Problem description

Fix the CLARIN license section so it uses the route-aware submission service instead of workspace-only lookups. This makes the component work against both workspace item edit pages and workflow item edit pages by loading the correct submission endpoint and sending the PATCH request to the submission’s own self link.

Copilot review

• Requested review from Copilot

[Copilot]

Pull request overview

This PR updates the CLARIN license submission section to work on both workspace item edit and workflow item edit pages by relying on the route-aware SubmissionService and PATCHing the submission object via its own self link.

Changes:

• Replace workspaceitem-only lookup logic with SubmissionService.retrieveSubmission(submissionId) to support both workspace and workflow edit routes.
• Send the license PATCH request directly to submission._links.self.href instead of constructing a workspaceitems endpoint URL.
• Adjust item/license initialization to resolve the item via submission._links.item.href.

Comments suppressed due to low confidence (2)

src/app/submission/sections/clarin-license-resource/section-license.component.ts:301

• buildFromRequestUUID(requestId) emits a completed RemoteData even on failures, where payload can be undefined. This code immediately dereferences/destructures response.payload (const workspaceitem = response.payload; const {sections} = workspaceitem; ...), which will throw if the PATCH fails (e.g. 4xx/5xx). Add a guard like if (!response?.hasSucceeded || !response.payload) { ... return; } before reading sections/errors, and handle the failure path (e.g. show an error notification).

          .subscribe((response: RemoteData<SubmissionObject>) => {

            // show validation errors in every section
            const workspaceitem = response.payload;

            const {sections} = workspaceitem;
            const {errors} = workspaceitem;

src/app/submission/sections/clarin-license-resource/section-license.component.ts:300

• The local variable name workspaceitem is misleading here because the response is now typed as RemoteData<SubmissionObject> and may represent either a workspace or workflow submission. Renaming it to something like submissionObject (and updating sections/errors destructuring) will make the code clearer and reduce confusion during maintenance.

            // show validation errors in every section
            const workspaceitem = response.payload;

            const {sections} = workspaceitem;
            const {errors} = workspaceitem;