Repository navigation
Docs: drop hard-coded current_year=2024 from FreshnessScorer examples - #2431
Open
SohamKukreti wants to merge 1 commit into
Open
SohamKukreti wants to merge 1 commit into
SohamKukreti wants to merge 1 commit into
Conversation
FreshnessScorer now defaults to the current year, so the examples use the default and note how to override it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2427 (addresses #2426).
FreshnessScorernow defaultscurrent_yearto the current year, but the LLM context docs still passedcurrent_year=2024in their examples. Readers who copy them get the old ranking: 2024 pages score highest, and newer pages score like undated ones.This PR removes the hard-coded year from the examples, so they use the default. A short comment on the standalone example says that
current_yeardefaults to this year and can be passed to score against another year.Merge after #2427.
List of files changed and why
docs/md_v2/assets/llm.txt/txt/deep_crawl_advanced_filters_scorers.txt- removecurrent_year=2024from bothFreshnessScorerexamples and add a comment on the default.docs/md_v2/assets/llm.txt/txt/llms-full.txt- the same change in the same examples.llms-full-v0.1.1.txtis the v0.1.1 snapshot, so it is not changed.How Has This Been Tested?
Docs only. The examples use only
weight, which is a valid argument before and after #2427. With #2427,FreshnessScorer(weight=...)scores against the current year (tested in that PR).Checklist: