ICU-11533 Myanmar / Burmese calendar support#4074
Conversation
| monthNames:alias{"/LOCALE/calendar/gregorian/monthNames"} | ||
| quarters:alias{"/LOCALE/calendar/gregorian/quarters"} | ||
| } | ||
| myanmar{ |
There was a problem hiding this comment.
this should go into CLDR-8081 first, as this file (root.txt) is generated from there.
There was a problem hiding this comment.
I faintly remembered I had a PR for CLDR. I am updating the commit to add names for the months to my.xml
unicode-org/cldr#3806
| // Test various dates to be sure of validity | ||
| int32_t data[] = { |
There was a problem hiding this comment.
you mentioned issues with testing. Note that ICU4C testing can use json now, https://github.com/unicode-org/icu/blob/main/icu4c/source/test/intltest/messageformat2test_read_json.cpp for example. So the test data could be in a json file if that helps.
|
oh and hi again 👋 |
|
Is there a ticket filed for this change, and can you link it to this PR? For CLDR it's CLDR-8081 and the PR is https://github.com/unicode-org/cldr/pull/3806/changes
The PR has a description. |
|
I have a couple of questions. What is the reference source for this calendar you used to verify you're getting correct dates? Did you verify it over the wider range of dates, or only spot checked? Also, I would like to see some unit tests for add() and roll(). I noticed that you didn't add any overrides for those two methods, so I am curios if that works as is, especially at leap years' boundaries and similar |
Background
A while ago I proposed PR #630 to add the Myanmar lunar-based calendar (aka Burmese calendar) to ICU. This calendar is frequently used for birthdays and on official documents.
After difficulties with supporting and testing a complete calendar, I closed the PR in 2024.
(Last year I suggested changing only the year in #3482 , which was rejected)
The reference for this work is https://github.com/yan9a/mmcal , an open source C++/JS project which gave their permission.
What's new?
On AI assistance:
Checklist