Skip to content

ICU-23460 Clean up registered collator always in CollationServiceTest#4083

Open
yumaoka wants to merge 1 commit into
unicode-org:mainfrom
yumaoka:icu23460-unregister-coll
Open

ICU-23460 Clean up registered collator always in CollationServiceTest#4083
yumaoka wants to merge 1 commit into
unicode-org:mainfrom
yumaoka:icu23460-unregister-coll

Conversation

@yumaoka

@yumaoka yumaoka commented Jul 17, 2026

Copy link
Copy Markdown
Member

In the original code, ICU4J CollationServiceTest may leave a collator registered for testing. When one of these test failed before unregistration, it will affect other test cases. Updated the code with try-finally to ensure a collator registered for testing will be unregistered after the test.

Checklist

  • Required: Issue filed: ICU-23460
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@yumaoka
yumaoka requested review from garywade and markusicu July 17, 2026 17:22
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@yumaoka
yumaoka requested a review from richgillam July 17, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant