Conversation
publish() in dispatch_inbound_envelope had a deferred create_task() path when direct_publish=False (the Pub/Sub callback code path). This caused BackupContactsEvent to be delivered AFTER UnifyMeetReceived, crashing the call handler with a NoneType error because the contact fallback cache was empty. Remove the dual-mode publish entirely — publish() now always awaits directly, eliminating the ordering hazard. Also add a null guard in start_unify_meet and a test that verifies subscriber delivery order through the real handle_message threading path.
Lead with architecture contribution rather than product pitch. Add "What's open and what's not" section that honestly explains the hosted backend dependency and path to replacing it. Reference OpenClaw and Hermes Agent as better choices for fully self-hosted setups. Promote local persistence layer to top of roadmap.
Recommend option 2 (CodeAct + simulated managers) as the default quickstart so new users see the full architecture end-to-end. Drop "Mode 1/2/3" jargon in favor of "option" references. Soften intro wording per review feedback.
Drop the roadmap (not actively being worked on) and the community links (Issues, Discussions, Discord) which are premature for the current state of the repo.
gpt-5.4-mini responds with terse deferrals ("One moment.") more often
than gpt-5-mini did. Accept deferral phrases alongside direct topic
engagement, since both satisfy the real intent: don't let a background
task hijack the response when the user asked for something specific.
call.py's configure_from_cli expects ASSISTANT_ID and USER_ID after ASSISTANT_BIO (added in b2d78a4), but the e2e test was never updated to pass them. The subprocess exited immediately with "Not enough arguments provided".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge staging fixes to main: comms publish ordering fix, gpt-5.4-mini eval update, e2e test arg fix.