[codex] Implement runtime entitlement gates#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntitlementGatefrom PR [codex] Implement Board-Man entitlement core MVP #73.Files changed
Clipy/Sources/Services/ClipService.swiftClipy/Sources/Services/Entitlement.swiftClipy/Sources/Managers/MenuManager.swiftClipy/Sources/Snippets/CPYSnippetsEditorWindowController.swiftClipyTests/EntitlementGateTests.swiftRuntime gates added
ClipService.save(with:)accepts new history items, then trims oldest entries toEntitlementGate.historyRetentionLimit().PinnedSnippetStore.add(_:)usesEntitlementGate.canPinItem(currentPinnedCount:)before adding a new pin.EntitlementGate.canCreateSnippet(currentSnippetCount:).EntitlementGate.canCreateSnippetFolder(currentFolderCount:).Free-limit behavior
Non-destructive behavior
Validation results
rtk git status --short: only pre-existing untracked_copy/remains after commit.rtk git diff --stat main...HEAD: 5 files changed, 90 insertions, 14 deletions.rtk git diff --check: passed.rtk git diff --cached --check: passed before commit.rtk xcodebuild -project Board-Man.xcodeproj -scheme Board-Man -configuration Debug -derivedDataPath "${TMPDIR:-/tmp}/BoardManCodexValidation" -destination 'generic/platform=macOS' -skipPackagePluginValidation -skipMacroValidation CODE_SIGNING_ALLOWED=NO build: passed.Tests / pure check
EntitlementGateTestsfor history retention, snippet folder limits, over-limit non-mutating behavior, and Pro runtime action allowance.IDELaunchServicesLauncherissue from PR [codex] Implement Board-Man entitlement core MVP #73.ENTITLEMENT_RUNTIME_GATE_CHECK=OK.Out of scope