[codex] Harden Board-Man upgrade CTA#77
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files changed
Board-Man.xcodeproj/project.pbxprojClipy/Sources/Preferences/CPYPreferencesWindowController.swiftClipy/Sources/Preferences/Panels/CPYBetaPreferenceViewController.swiftClipy/Sources/Services/BoardManUpgradeRoute.swiftURL helper added/updated
BoardManUpgradeRoute.openProPage()with the canonical URLhttps://uniplanck.com/board-man.Call sites changed
openBuyPro()now callsBoardManUpgradeRoute.openProPage().openBoardManProUpgrade()now callsBoardManUpgradeRoute.openProPage().Validation results
git status --short: expected branch changes only before commit, with unrelated untracked_copy/left unstaged.git diff --stat: 4 files changed, 27 insertions, 2 deletions.git diff --check: passed.rtk xcodebuild -project Board-Man.xcodeproj -scheme Board-Man -configuration Debug -derivedDataPath "${TMPDIR:-/tmp}/BoardManCodexValidation" -destination 'generic/platform=macOS' -skipPackagePluginValidation -skipMacroValidation CODE_SIGNING_ALLOWED=NO build: passed with existing SwiftLint warnings.\n\n## Explicitly out of scope\n- UI redesign\n- purchase flow\n- real license activation\n- backend activation\n- Keychain device binding\n- Sparkle release/appcast