Skip to content

feat(vm-manager): add Cloud-Init support for Unraid VMs #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
retrozenith wants to merge 14 commits into
base: master
Choose a base branch
from
+580 −7
Open

feat(vm-manager): add Cloud-Init support for Unraid VMs #2536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f25f58f
feat(vm-manager): add Cloud-Init support for Unraid VMs
retrozenith Jan 28, 2026
13ca518
fix(vm-manager): interactive editor ignoring form changes
retrozenith Jan 29, 2026
179fb41
refactor(vm-manager): deduplicate cloud-init yaml generation
retrozenith Jan 29, 2026
dd3bdf4
fix(vm-manager): mitigate yaml injection in cloud-init generation
retrozenith Jan 29, 2026
1920e9c
fix(vm-manager): improve safety and cleanup in cloud-init handling
retrozenith Jan 29, 2026
7e82cbb
chore(vm-manager): remove temporary debug logging
retrozenith Jan 29, 2026
e367e61
fix(libvirt): reset output buffer in cloud-init iso creation
retrozenith Jan 29, 2026
fced67a
fix(libvirt): whitelist allowed disk device types in libvirt XML gene…
retrozenith Jan 29, 2026
8ad110d
fix(vm-manager): improve cloud-init ISO handling and error reporting
retrozenith Jan 29, 2026
a0f44b6
fix(vm-manager): correct disk schema regression in updatevm path
retrozenith Jan 29, 2026
7d65ad9
fix(vm-manager): add error handling for cloud-init in updatevm
retrozenith Jan 29, 2026
b65ba92
fix(vm-manager): resolve duplicate cloud-init disks and improve ISO h…
retrozenith Jan 29, 2026
1e6026a
fix(vm-manager): harden custom ISO path validation against traversal
retrozenith Jan 29, 2026
0ecb081
Merge branch 'master' into feat/cloud-init
retrozenith Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion emhttp/plugins/dynamix.vm.manager/include/libvirt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,8 @@ function config_to_xml($config, $vmclone=false) {
if ($strDevType == 'file' || $strDevType == 'block') {
$strSourceType = ($strDevType == 'file' ? 'file' : 'dev');
if (isset($disk['discard'])) $strDevUnmap = " discard=\"{$disk['discard']}\" "; else $strDevUnmap = " discard=\"ignore\" ";
$diskstr .= "<disk type='".$strDevType."' device='disk'>
$strDevice = $disk['device'] ?? 'disk';
$diskstr .= "<disk type='".$strDevType."' device='".$strDevice."'>
<driver name='qemu' type='".$disk['driver']."' cache='writeback'".$strDevUnmap."/>
<source ".$strSourceType."='".htmlspecialchars($disk['image'], ENT_QUOTES | ENT_XML1)."'/>
<target bus='".$disk['bus']."' dev='".$disk['dev']."' $rotation_rate />
Expand Down
62 changes: 62 additions & 0 deletions emhttp/plugins/dynamix.vm.manager/include/libvirt_helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,68 @@
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*/

function create_cloud_init_iso($strPath, $strUserData, $strNetworkConfig) {
$strPath = rtrim($strPath, '/');
if (!is_dir($strPath)) {
return false;
}

$strImgPath = $strPath . '/cloud-init.img';
$strMountPoint = $strPath . '/cloud-init-mount';

// Create blank 4MB image
exec("dd if=/dev/zero of=" . escapeshellarg($strImgPath) . " bs=1M count=4 2>&1", $output, $return_var);
if ($return_var !== 0) {
error_log("Cloud-Init image creation failed (dd): " . implode("\n", $output));
return false;
}

// Format as VFAT with label 'cidata' (try mkfs.vfat first, then mkdosfs)
$output = [];
exec("which mkfs.vfat mkdosfs 2>/dev/null | head -n1", $mkfsTool);
$mkfsCmd = !empty($mkfsTool[0]) ? $mkfsTool[0] : '/sbin/mkdosfs';

exec($mkfsCmd . " -n cidata " . escapeshellarg($strImgPath) . " 2>&1", $output, $return_var);
if ($return_var !== 0) {
error_log("Cloud-Init image formatting failed (vfat): " . implode("\n", $output));
return false;
}

// Create mount point
if (!is_dir($strMountPoint)) {
mkdir($strMountPoint, 0777, true);
}

// Mount image
exec("mount -o loop " . escapeshellarg($strImgPath) . " " . escapeshellarg($strMountPoint) . " 2>&1", $output, $return_var);
if ($return_var !== 0) {
error_log("Cloud-Init image mount failed: " . implode("\n", $output));
return false;
}

// Write files
file_put_contents($strMountPoint . '/user-data', $strUserData);
if (!empty($strNetworkConfig)) {
file_put_contents($strMountPoint . '/network-config', $strNetworkConfig);
}
file_put_contents($strMountPoint . '/meta-data', "instance-id: " . uniqid() . "\nlocal-hostname: localhost\n");
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

// Sync and Unmount
exec("sync");
exec("umount " . escapeshellarg($strMountPoint) . " 2>&1", $output, $return_var);

// Clean up mount point
rmdir($strMountPoint);

if ($return_var !== 0) {
error_log("Cloud-Init image unmount failed: " . implode("\n", $output));
return false;
}
Comment thread
retrozenith marked this conversation as resolved.

return $strImgPath;
}

?>
<?
/**
Expand Down
Loading