Skip to content

Remove -k flag from notification agents using public APIs#2607

Open
Sacred-Shadow wants to merge 7 commits intounraid:masterfrom
Sacred-Shadow:Sacred-Shadow-patch-2
Open

Remove -k flag from notification agents using public APIs#2607
Sacred-Shadow wants to merge 7 commits intounraid:masterfrom
Sacred-Shadow:Sacred-Shadow-patch-2

Conversation

@Sacred-Shadow
Copy link
Copy Markdown

@Sacred-Shadow Sacred-Shadow commented Apr 3, 2026

The -k flag disables TLS certificate validation in curl. Among the existing notification agents, I found 7 that call public APIs with valid SSL certificates but still use -k unnecessarily.

Affected agents: Boxcar, Join, Prowl, Pushbullet, Pushover, Pushplus, ServerChan.

I was able to reach all 7 APIs and confirmed that each one presents a valid SSL certificate.
There is therefore no reason to use -k.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced TLS certificate verification for notification services (Boxcar, Join, Prowl, Pushbullet, Pushover, Pushplus, ServerChan) to enforce valid certificates and improve notification system security.

-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e9a7dd2c-fdb3-46ba-8160-ef8219da765f

📥 Commits

Reviewing files that changed from the base of the PR and between 16bff4a and 9860d72.

📒 Files selected for processing (7)
  • emhttp/plugins/dynamix/agents/Boxcar.xml
  • emhttp/plugins/dynamix/agents/Join.xml
  • emhttp/plugins/dynamix/agents/Prowl.xml
  • emhttp/plugins/dynamix/agents/Pushbullet.xml
  • emhttp/plugins/dynamix/agents/Pushover.xml
  • emhttp/plugins/dynamix/agents/Pushplus.xml
  • emhttp/plugins/dynamix/agents/ServerChan.xml

Walkthrough

Seven notification agent scripts in the dynamix plugin were updated to enforce TLS certificate verification by removing the -k flag from curl commands. The flag previously disabled certificate validation; all other request parameters, HTTP methods, endpoints, and output handling remain unchanged.

Changes

Cohort / File(s) Summary
TLS Certificate Verification Enhancement
emhttp/plugins/dynamix/agents/Boxcar.xml, emhttp/plugins/dynamix/agents/Join.xml, emhttp/plugins/dynamix/agents/Prowl.xml, emhttp/plugins/dynamix/agents/Pushbullet.xml, emhttp/plugins/dynamix/agents/Pushover.xml, emhttp/plugins/dynamix/agents/Pushplus.xml, emhttp/plugins/dynamix/agents/ServerChan.xml
Removed the -k flag from curl invocations in all notification agent scripts, enabling TLS certificate verification. Request methods, endpoints, headers, payloads, and output redirection remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Seven agents now stand tall with trust,
No more -k flags—security's a must!
Certificates verified, connections made tight,
Notifications fly safely through the night! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the -k flag from notification agent scripts. It clearly identifies both the action (remove -k flag) and the scope (notification agents using public APIs), which aligns with all seven files modified in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant