Remove -k flag from notification agents using public APIs#2607
Remove -k flag from notification agents using public APIs#2607Sacred-Shadow wants to merge 7 commits intounraid:masterfrom
Conversation
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
-k removed from curl, as the public API uses a valid certificate.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughSeven notification agent scripts in the dynamix plugin were updated to enforce TLS certificate verification by removing the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The
-kflag disables TLS certificate validation in curl. Among the existing notification agents, I found 7 that call public APIs with valid SSL certificates but still use-kunnecessarily.Affected agents: Boxcar, Join, Prowl, Pushbullet, Pushover, Pushplus, ServerChan.
I was able to reach all 7 APIs and confirmed that each one presents a valid SSL certificate.
There is therefore no reason to use
-k.Summary by CodeRabbit