feat: golang module support pseudo version#8293
Merged
olblak merged 3 commits intoupdatecli:mainfrom Apr 5, 2026
Merged
Conversation
Signed-off-by: Olblak <me@olblak.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Go module resource to better handle modules that don’t publish tagged versions by falling back to Go proxy pseudo-versions (via @latest) when using “latest”-style filters, and updates the condition check to query specific versions via the Go proxy .info endpoint.
Changes:
- Refactors proxy version retrieval into helper functions and trims/normalizes list responses.
- Adds
@latestJSON parsing to support pseudo-version fallback when no versions are published. - Updates
Conditionto check for a specific version using@v/<version>.infoinstead of scanning the full version list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| pkg/plugins/resources/go/module/version.go | Adds proxy helpers and @latest fallback logic to return pseudo-versions when no tagged versions exist. |
| pkg/plugins/resources/go/module/condition.go | Switches condition checks to use the proxy .info endpoint per version and aligns GOPROXY resolution logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* use constant for version filter kind * trimspace around proxy * handle correctly http error Signed-off-by: Olblak <me@olblak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support pseudo version such as
github.com/shurcooL/githubv4 v0.0.0-20230215024106-420ad0987b9bfor golang moduleTest
To test this pull request, you can run the following commands:
pkg/plugins/resources/go/module/ go testAdditional Information
Checklist
Tradeoff
Potential improvement