Skip to content

fix: avoid attacker controlling PR number #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
upils merged 1 commit into from
Apr 21, 2026
Merged

fix: avoid attacker controlling PR number #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/comment-perf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,22 @@ jobs:
- name: Download comment
uses: actions/download-artifact@v4
with:
name: benchmark-result
path: benchmark-result
name: benchmark-report
path: report.md
github-token: ${{ secrets.ROCKSBOT_CHISEL_PR_COMMENTER }}
run-id: ${{ github.event.workflow_run.id }}

- name: Read PR number
id: read-pr-number
run: echo "number=$(cat benchmark-result/pr_number)" >> $GITHUB_OUTPUT
- name: Get PR number
id: get-pr-number
run: |
PR_NUMBER=$(gh api "repos/${{ github.repository }}/pulls?head=${{ github.event.workflow_run.head_repository.owner.login }}:${{ github.event.workflow_run.head_branch }}&state=open" --jq '.[0].number')
echo "number=$PR_NUMBER" >> $GITHUB_OUTPUT
env:
GH_TOKEN: ${{ secrets.ROCKSBOT_CHISEL_PR_COMMENTER }}

- name: Post message to PR
uses: mshick/add-pr-comment@dd126dd8c253650d181ad9538d8b4fa218fc31e8 # v2
with:
message-path: benchmark-result/report.md
issue: ${{ steps.read-pr-number.outputs.number }}
message-path: report.md
issue: ${{ steps.get-pr-number.outputs.number }}
repo-token: ${{ secrets.ROCKSBOT_CHISEL_PR_COMMENTER }}
9 changes: 2 additions & 7 deletions .github/workflows/performance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,9 @@ jobs:
chmod +x base head
hyperfine --export-markdown report.md "./base info --release ./chisel-releases 'python3.12_core'" -n "BASE" "./head info --release ./chisel-releases 'python3.12_core'" -n "HEAD"

- name: Save PR number
run: echo "${{ github.event.pull_request.number }}" > pr_number

- name: Upload result
uses: actions/upload-artifact@v4
with:
name: benchmark-result
path: |
report.md
pr_number
name: benchmark-report
path: report.md
retention-days: 1
Loading