fix: skill installation path check compatibility for Windows#2441
Merged
fahreddinozcan merged 3 commits intoupstash:masterfrom Apr 13, 2026
Merged
fix: skill installation path check compatibility for Windows#2441fahreddinozcan merged 3 commits intoupstash:masterfrom
fahreddinozcan merged 3 commits intoupstash:masterfrom
Conversation
fahreddinozcan
approved these changes
Apr 13, 2026
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path security check in
installSkillFileswas hardcoded to use forward slashes (/).On Windows systems,
path.resolvereturns backslashes (\), causing valid paths to berejected with an "outside the target directory" error.
This PR adds a check for backslashes to ensure cross-platform compatibility.