Add -NoProfile to elevated Run-Command subprocess#41
Merged
Conversation
The elevated powershell.exe process spawned by Run-Command loads the user's profile, which can cause hangs when the profile contains interactive commands (e.g. a PS5→PS7 redirect guard). Adding -NoProfile skips profile loading, which is correct for a utility subprocess that only runs a single command.
Verifies that Run-Command passes -NoProfile to the elevated powershell.exe subprocess, preventing user profiles from interfering with the command execution.
Collaborator
|
Hey @mattlindell thank you very much for the PR Thanks again. |
Contributor
Author
Sure thing, I'll implement and push changes after work today. Thank you for the feedback! |
Collaborator
Thank you |
Remove helpers.ps1 dot-source from Run-Command test — pvm.ps1 loads it when running `pvm test`. Mirror Run-Command's -NoProfile fix in pvm.bat so the top-level launcher also skips profile load.
Contributor
Author
|
Both addressed in c0eba12:
|
Collaborator
Am merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run-Commandspawnspowershell.exewith-Verb RunAsbut loads the user's profile. If the profile contains interactive commands (e.g. a PS5→PS7 redirect), the hidden window hangs indefinitely.Adding
-NoProfilefixes this: an elevated subprocess running a single command has no need for user profiles.Test plan
-NoProfileis passed toStart-Process