feat rabbitmq: Support for queue optional args and queue.declare-ok response#1294
Open
alex-aparin wants to merge 2 commits into
Open
feat rabbitmq: Support for queue optional args and queue.declare-ok response#1294alex-aparin wants to merge 2 commits into
alex-aparin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases, when we need to use so called queue's optional args like maximal message count per queue etc. Out the box userver does not provide such feature. I have added this via already implemented HeaderValue class (to wrap amqp's Table) + have added response from DeclareQueue in order to carefully check optional args in unit tests
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.