Repository navigation
fix(remove): delete the build images of the removed containers - #50
Merged
Merged
Conversation
The deploy-time 72h prune skips images a kept container still uses, and remove took the containers without their images, so a removed app's <app>-build-* images stayed forever. Names come from the app's own containers, removal is never forced, pulled images are untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Containers created by image ID report the ID in docker ps, so the name check missed their build images (found live on infra-home). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
teploy removeleft every<app>-build-<version>image behind: the deploy-time 72h image prune skips images that a kept (stopped) container still uses, and remove deleted those containers but not their images. Found during the D4 live test (a purged throwaway app left its build image).x-build) are never matched.docker rmiwithout force: an image still used by another container stays. Failures never fail the remove.--jsonreportsremoved_images(omitempty; remove JSON is not a contracts artifact).--purgeis intentional: it is the audit trail of who removed the app.Also fixes a missing blank line in
trigger_identity.go(gofmt) from #48.Test:
TestExecuteRemoveDeletesItsBuildImages.🤖 Generated with Claude Code