Harden world loading against missing void generator#142
Merged
Conversation
Member
Author
|
CI note: the |
7699c8d to
c8ea85d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the silent failure where the skyblock world runs with the vanilla generator and regular terrain generates around islands (reported as "creates an overworld underneath my island"). Bukkit never persists plugin generators, and
createWorld()silently returns already-loaded worlds unchanged — so a world loaded by the server (level-name) or a generator-less Multiverse registration stayed broken with no diagnostics.WorldManagernow verifies the attached generator after world load/creation and logs an actionable SEVERE banner (bukkit.yml snippet, recovery command) when it cannot be attached.worlds.<name>.generator: uSkyBlockin bukkit.yml when missing — the only mechanism covering every load path, including the default world. Add-only-when-missing, never overwrites admin values, fail-soft on read-only or unparseable files./usb chunk regen.Explicitly excluded: persisting a flat-void stem via
WorldType.FLAT— on 1.21.2+ that hardcodes sea level to -63 and breaks sea-level-anchored mob spawning (squid/dolphin/fish, glow squid, drowned, turtles) plus the guardian-habitat mechanic (same reason BSkyBlock reverted FLAT, BentoBox#2593).Test Plan
:uSkyBlock-Core:testsuite green (176 tests)level-name=skyworldwithout mapping → boot 1 logs both banners and writes both bukkit.yml entries; boot 2 starts clean with the server loading the default world through the plugin generator🤖 Generated with Claude Code