Skip to content

tidying up jokes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dan-waters wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tidying up jokes #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e53de7
tidying up jokes
dan-waters Apr 22, 2015
6231f80
Using api to correct name
dan-waters Apr 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dashing.conf/jobs/icndb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@

# Convert to JSON and save joke
j = JSON[response.body]
@@joke = j['value']['joke']
@@joke = j['value']['joke'].gsub('Chuck Norris', 'Usman')
Copy link
Copy Markdown
Owner

@usmanatron usmanatron Apr 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄
There is however a way to do this via the icndb API - have a look at: http://www.icndb.com/api/ (look for "Changing the name of the main character"), which I think would be nicer!

EDIT: Also, I've just thought... would be nice to make this an environment variable to make it easy to change (otherwise you have to mess with the code and build the container again, which is a faff)




end

SCHEDULER.every '10s', :first_in => 0 do |job|
send_event('motd', { message: "#{@@joke}", origin: 'auto' })
end
end