TURBOPACK: re-export circular cause egaer evaluation#144
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates ESM module evaluation to use EcmascriptModuleFacadeModule instead of EcmascriptModuleLocalsModule to prevent re-entry issues in barrel files. It also updates facade modules to report side effects from their underlying modules. A potential correctness issue was identified where changing follow_reexports to non-eager resolution might fail to resolve multi-step re-export chains when the export name remains unchanged.
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 26, 2026
yuzheng14
pushed a commit
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.