Skip to content

fix(pack): script external export compitable #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fireairforce merged 1 commit into from
Apr 27, 2026
Merged

fix(pack): script external export compitable #2828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/pack-tests/tests/snapshot/externals/async-script-externals/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
}
],
"externals": {
"lodash": "script _@https://gw.alipayobjects.com/os/lib/lodash/4.17.21/lodash.min.js"
"lodash": "script _@https://gw.alipayobjects.com/os/lib/lodash/4.17.21/lodash.min.js",
"jszip": "script JSZip@https://gw.alipayobjects.com/os/lib/jszip/3.10.1/dist/jszip.min.js"
}
}
}
6 changes: 6 additions & 0 deletions crates/pack-tests/tests/snapshot/externals/async-script-externals/input/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
import JSZip from 'jszip';

const zip = new JSZip();

zip;

const func = async () => {
// @ts-ignore
const _ = await import('lodash');
Expand Down
5 changes: 4 additions & 1 deletion ...ck-tests/tests/snapshot/externals/async-script-externals/output/_externals____2fc6bb03.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ var mod = await (async () => {
throw error;
})();

__turbopack_context__.v(mod);
var ns = Object.create(null);
for (var key in mod) ns[key] = mod[key];
Comment thread
fireairforce marked this conversation as resolved.
ns.default = mod;
__turbopack_context__.n(ns);
__turbopack_async_result__();
} catch(e) { __turbopack_async_result__(e); } }, true);}),
]);
62 changes: 62 additions & 0 deletions .../tests/snapshot/externals/async-script-externals/output/_root-of-the-server___d0ad72cc.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions ...ts/snapshot/externals/async-script-externals/output/_root-of-the-server___d0ad72cc.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 0 additions & 25 deletions .../tests/snapshot/externals/async-script-externals/output/_root-of-the-server___d1c9390f.js
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions ...ts/snapshot/externals/async-script-externals/output/_root-of-the-server___d1c9390f.js.map
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions crates/pack-tests/tests/snapshot/externals/async-script-externals/output/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
(globalThis["TURBOPACK"] || (globalThis["TURBOPACK"] = [])).push([
typeof document === "object" ? document.currentScript : undefined,
{"otherChunks":["_root-of-the-server___d1c9390f.js"],"runtimeModuleIds":["[project]/externals/async-script-externals/input/index.ts [client] (ecmascript)"]}
{"otherChunks":["_root-of-the-server___d0ad72cc.js"],"runtimeModuleIds":["[project]/externals/async-script-externals/input/index.ts [client] (ecmascript)"]}
]);
// Dummy runtime
// Dummy runtime
10 changes: 8 additions & 2 deletions crates/pack-tests/tests/snapshot/externals/basic/output/_root-of-the-server___3b647096.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...es/pack-tests/tests/snapshot/externals/basic/output/_root-of-the-server___3b647096.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion crates/pack-tests/tests/snapshot/externals/script/output/_externals____2fc6bb03.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ var mod = await (async () => {
throw error;
})();

__turbopack_context__.v(mod);
var ns = Object.create(null);
for (var key in mod) ns[key] = mod[key];
ns.default = mod;
__turbopack_context__.n(ns);
__turbopack_async_result__();
} catch(e) { __turbopack_async_result__(e); } }, true);}),
]);
4 changes: 1 addition & 3 deletions crates/pack-tests/tests/snapshot/public_path/basic/output/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions crates/pack-tests/tests/snapshot/public_path/basic/output/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions crates/pack-tests/tests/snapshot/public_path/runtime/output/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions crates/pack-tests/tests/snapshot/public_path/runtime/output/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions crates/pack-tests/tests/snapshot/runtime/app_build_runtime/output/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions crates/pack-tests/tests/snapshot/runtime/app_build_runtime/output/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions crates/pack-tests/tests/snapshot/runtime/app_dev_runtime/output/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions crates/pack-tests/tests/snapshot/runtime/app_dev_runtime/output/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions crates/pack-tests/tests/snapshot/runtime/cross_origin_loading_anonymous/output/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions crates/pack-tests/tests/snapshot/runtime/cross_origin_loading_anonymous/output/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions crates/pack-tests/tests/snapshot/runtime/export_entry_exports/output/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions crates/pack-tests/tests/snapshot/runtime/export_entry_exports/output/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion next.js
Open in desktop
Submodule next.js updated 3 files
+20 −18 Cargo.lock
+1 −3 turbopack/crates/turbopack-ecmascript-runtime/js/src/browser/runtime/base/runtime-base.ts
+5 −0 turbopack/crates/turbopack-ecmascript/src/references/external_module.rs
Loading