-
Notifications
You must be signed in to change notification settings - Fork 4
Joins #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Joins #133
Changes from 11 commits
1d86a6b
ae04b11
98dd145
01e06cf
6a95abb
f2c5f6a
53ce92c
67c8eda
69ade1c
066bd70
49bddeb
f50c5ad
805bdb8
317e4c9
bfafb18
525ba8c
bc73611
fb8378a
fd6b9bc
4030ff3
daa5f17
0a632aa
d115b61
9aeb2d5
ac60b6d
4582154
db744ef
6817db3
b1c5095
63df4dd
3a33326
e60685a
7b1750f
19feff6
b41b305
32da357
c030a2a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1142,7 +1142,9 @@ private function exportRows(int $batchSize): void | |||||||||||||||||||
| } | ||||||||||||||||||||
| /** @var Column|Relationship $attribute */ | ||||||||||||||||||||
|
|
||||||||||||||||||||
| $queries[] = $this->database->querySelect($selects); | ||||||||||||||||||||
| foreach ($selects as $select) { | ||||||||||||||||||||
| $queries[] = $this->database->querySelect($select); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stale PHPDoc annotation causes pipeline failure. The Remove or relocate the stale PHPDoc comment. 🔎 Proposed fix- /** @var Column|Relationship $attribute */
-
foreach ($selects as $select) {
$queries[] = $this->database->querySelect($select);
}📝 Committable suggestion
Suggested change
🧰 Tools🪛 GitHub Actions: CodeQL[error] 1146-1146: PHPStan: Variable $attribute in PHPDoc tag @var does not match any variable in the foreach loop: $selects, $select 🤖 Prompt for AI Agents |
||||||||||||||||||||
|
|
||||||||||||||||||||
| $response = $this->database->listRows($table, $queries); | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -360,12 +360,12 @@ public function getRow(TableResource $resource, string $rowId, array $queries = | |||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| /** | ||||||||||||||||||
| * @param array $columns | ||||||||||||||||||
| * @param string $column | ||||||||||||||||||
| * @return Query | ||||||||||||||||||
| */ | ||||||||||||||||||
| public function querySelect(array $columns): Query | ||||||||||||||||||
| public function querySelect(string $column): Query | ||||||||||||||||||
| { | ||||||||||||||||||
| return Query::select($columns); | ||||||||||||||||||
| return Query::select($column); | ||||||||||||||||||
| } | ||||||||||||||||||
|
fogelito marked this conversation as resolved.
Comment on lines
421
to
423
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| /** | ||||||||||||||||||
|
|
||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.