Fix Mongo transport recovery after socket failures#43
Conversation
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR improves Mongo transport recovery after socket failures. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "test: clarify transport recovery contrac..." | Re-trigger Greptile |
| if ($headerData['opCode'] !== 2013) { | ||
| $this->invalidate(); | ||
| throw new Exception('Invalid response operation code: ' . $headerData['opCode']); | ||
| } |
There was a problem hiding this comment.
This hard-codes successful responses to opCode 2013. If a supported deployment or proxy returns a valid legacy OP_REPLY response, the client now treats it as corruption, closes the socket, and every operation on that connection fails with Invalid response operation code.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Client.php
Line: 1749-1752
Comment:
**Legacy Replies Are Rejected**
This hard-codes successful responses to `opCode` 2013. If a supported deployment or proxy returns a valid legacy `OP_REPLY` response, the client now treats it as corruption, closes the socket, and every operation on that connection fails with `Invalid response operation code`.
How can I resolve this? If you propose a fix, please make it concise.
Summary
Validation