Skip to content

backup_control.rs: remove unsafe & Mutex#12290

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:unsafe-mutex
Open

backup_control.rs: remove unsafe & Mutex#12290
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:unsafe-mutex

Conversation

@oech3

@oech3 oech3 commented May 14, 2026

Copy link
Copy Markdown
Contributor

maybe, closes #12240

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tty-eof (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/expand/bounded-memory is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@oech3
oech3 marked this pull request as ready for review May 14, 2026 12:52
@codspeed-hq

codspeed-hq Bot commented May 15, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 132 untouched benchmarks
⏩ 253 skipped benchmarks1


Comparing oech3:unsafe-mutex (ebdd879) with main (ef50d8b)

Open in CodSpeed

Footnotes

  1. 253 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
oech3 force-pushed the unsafe-mutex branch 2 times, most recently from 1814185 to 19d9994 Compare May 27, 2026 08:04
@oech3
oech3 force-pushed the unsafe-mutex branch 2 times, most recently from 9fa2513 to d6ca086 Compare July 17, 2026 14:21
@oech3 oech3 closed this Jul 17, 2026
@oech3
oech3 deleted the unsafe-mutex branch July 17, 2026 14:23
@oech3
oech3 restored the unsafe-mutex branch July 18, 2026 13:05
@oech3 oech3 reopened this Jul 18, 2026
@oech3
oech3 force-pushed the unsafe-mutex branch 3 times, most recently from 83d034e to e7a72c8 Compare July 18, 2026 15:51
@oech3

oech3 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Is this OK to merge?

@oech3

oech3 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@cakebaker Would you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant