Skip to content

mkfifo: don't delete fifo and fail when --context is used without SELinux/SMACK#13313

Open
Chaganti-Reddy wants to merge 2 commits into
uutils:mainfrom
Chaganti-Reddy:mkfifo-context-warning
Open

mkfifo: don't delete fifo and fail when --context is used without SELinux/SMACK#13313
Chaganti-Reddy wants to merge 2 commits into
uutils:mainfrom
Chaganti-Reddy:mkfifo-context-warning

Conversation

@Chaganti-Reddy

Copy link
Copy Markdown
Contributor

mkfifo currently deletes the fifo it just created and exits with a fatal error if --context is used on a kernel without SELinux/SMACK. same root cause as the mkdir bug, GNU just creates the fifo and warns instead. added the missing branch so it only bails out for real SELinux errors now, not for "not enabled".

Fixes #12983

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/expand/bounded-memory is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@codspeed-hq

codspeed-hq Bot commented Jul 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 172 untouched benchmarks
⏩ 213 skipped benchmarks1


Comparing Chaganti-Reddy:mkfifo-context-warning (a0a8cb7) with main (ef50d8b)

Open in CodSpeed

Footnotes

  1. 213 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(mkfifo): when using --context in Non Selinux kernel, it does not warn

2 participants