ptx: avoid per-word filename clones and line rescans for performance/…#13475
Closed
Aisha630 wants to merge 1 commit into
Closed
ptx: avoid per-word filename clones and line rescans for performance/…#13475Aisha630 wants to merge 1 commit into
Aisha630 wants to merge 1 commit into
Conversation
…memory improvement Store a `file_idx` into `FileMap` on each `WordRef` instead of cloning the filename per word, and index the map directly instead of scanning it by name and line range on every output line. Also cache the keyword's character offset (`char_position`) computed during `create_word_set`, so `prepare_line_chunks` no longer rescans the line prefix on each call. ptx: avoid per-word filename clones and line rescans for performance/memory improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…memory improvement
Store a
file_idxintoFileMapon eachWordRefinstead of cloning the filename per word, and index the map directly instead of scanning it by name and line range on every output line. Also cache the keyword's character offset (char_position) computed duringcreate_word_set, soprepare_line_chunksno longer rescans the line prefix on each call.ptx: avoid per-word filename clones and line rescans for performance/memory improvement