chgrp: fix error message for --from nonexisting_group GROUP#13490
Open
cakebaker wants to merge 3 commits into
Open
chgrp: fix error message for --from nonexisting_group GROUP#13490cakebaker wants to merge 3 commits into
--from nonexisting_group GROUP#13490cakebaker wants to merge 3 commits into
Conversation
because "staff" doesn't exist on Arch Linux and so test_from_with_invalid_group fails there
and show the same msg for "--from nonexisting GROUP", independent of whether GROUP exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
test_from_with_invalid_groupfails on my machine with Arch Linux whereas it works in the CI. The reason was that the test assumed a "staff" group exists, which is not the case on Arch Linux, and so the code didn't return the expected error message.This PR applies three changes:
--from nonexisting_group GROUP, independent of whetherGROUPexists