Breaking: Adapt coreutils dev file structure V2#206
Open
GunterSchmidt wants to merge 10 commits intouutils:mainfrom
Open
Breaking: Adapt coreutils dev file structure V2#206GunterSchmidt wants to merge 10 commits intouutils:mainfrom
GunterSchmidt wants to merge 10 commits intouutils:mainfrom
Conversation
For Code Spell Checker extension.
The file structure with * bin for the main executable * uu for the utilities * uudiff for the libraries was introduced. To minimize changes, only these changes were done: * move files to uu_ subdirectories * main() --> uumain() * bin/diffutils.rs replaces old main This required: * adjust modules in files * adjust paths in tests Whenever possible, methods of coreutils were used directly. For localization reasons, some modules needed to be copied and adapted for diffutils. Issues: The tool dist was adapted as much as possible but may not work with this setup. * requires all packages to be in the same repository * possibly requires a separate README.md for each tool
* use clap parser * internationalization of error and info messages, e.g. --help * moved tests into tests by-util * separated and moved benches * adapted fuzzer * common parser error handling for all modules * some fixes, e.g. error on selection of a directory
* use clap parser (10x faster) * parser implements all options with not yet implemented error * internationalization of error and info messages, e.g. help * moved main tests (still has some module tests) * separated and moved benches * clean up old code * adapted fuzzer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapting the project structure to the coreutils structure.
This replaces PR #201.
TL;DR: Diff and Cmp now in separate folders with clap parser and international help, info and error messages. Tests and Bench adapted.
coreutils uses a source code tree, which has each tool in a separate dir unter /uu,
a separate library tree and the main file under /bin. Also a number of features are
available in another directory.
Adaptiong this structure allows more usage of the coreutils macros
and methods. It makes it easier for the developers to navigate when
working in both projects.
Each utility can now be opened standalone
which makes it also easier to test and benchmark.
Since it is a file location restructure, the commit is containing
a lot of files. The core compare logic was left unchanged as much as
possible.
This PR contains a number of commits so the change steps become clearer.
Update of utils 'diff' and 'cmp':
not yet implemented error vs unexpected option
info messages, e.g. help
(still has some module tests)