fix!: remove not working helper-above variants from CheckboxVariant#9293
Merged
Conversation
jouni
approved these changes
May 15, 2026
knoobie
reviewed
May 15, 2026
| */ | ||
| @Deprecated | ||
| AURA_HELPER_ABOVE_FIELD("helper-above-field"), | ||
| HELPER_ABOVE("helper-above-field"); |
Contributor
There was a problem hiding this comment.
Suggestion: Instead of deleting the whole enum and possible create compile problems for people that rely on the fact that typically fields have HasThemeVariant<?> - just delete the enum variants leaving an empty class for later use-cases.
Member
Author
There was a problem hiding this comment.
Thanks, done. Also added AURA_SMALL which is actually supported to avoid empty enum.
web-padawan
force-pushed
the
fix/remove-checkbox-variant
branch
from
ccba95c to
9b85ef5
Compare
web-padawan
changed the title
|
vursen
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/web-components#11750
The only variant in
CheckboxVariantishelper-above-fieldand it does nothing. Let's remove it as agreed.Type of change