Skip to content

Fix/Post 1.1.3 test adjustments#4

Open
jooname wants to merge 6 commits into
mainfrom
fix/post-113-test-adjustments
Open

Fix/Post 1.1.3 test adjustments#4
jooname wants to merge 6 commits into
mainfrom
fix/post-113-test-adjustments

Conversation

@jooname

@jooname jooname commented May 6, 2026

Copy link
Copy Markdown
  • Fixed issue in one of the module unit tests caused by changes done in recent release
  • For now removing domain manager usage from one of the integration test fixtures, since to do this properly we need to create a rollback for this fixture and whatever other fixtures are using it. After all app/etc/env.php changes are not reverted automatically and changes to it will be validated after running tests, causing the running of test to be halted.
  • Updated sales rule fixtures for integration tests to use the AbstractModel save method, as on Commerce indexer logic is tied to save events of AbstractModel rather than resource model
  • Updated one of the product fixtures to grab the saved product instance, as it seems on Commerce the option saving doesn't result in the given product instance being updated, which results in the following fixture code breaking
  • Added some new integration test fixtures and also rollbacks in case the tests need to be done without database isolation

jooname added 6 commits May 6, 2026 09:44
…t fixtures, since to do this properly we need to create a rollback for this fixture and whatever other fixtures are using it. After all app/etc/env.php changes are not reverted automatically and changes to it will be validated after running tests, causing the running of test to be halted.
…Model save method, as on Commerce indexer logic is tied to save events of AbstractModel rather than resource model
…e, as it seems on Commerce the option saving doesn't result in the given product instance being updated, which results in the following fixture code breaking
…s in case the tests need to be done without database isolation
…oper region information, as the region validation is more strict in 2.4.5 and 2.4.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant