Skip to content

fix(pi): parse OMP title-before-session logs #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timseriakov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pi): parse OMP title-before-session logs #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,13 +743,34 @@ function parsePiSessionFile(sessionFile) {
if (lines.length === 0) return null;

let header;
try { header = JSON.parse(lines[0]); } catch { return null; }
if (!header || header.type !== 'session' || !header.id) return null;
let headerLine = -1;
for (let i = 0; i < Math.min(lines.length, 50); i++) {
try {
const entry = JSON.parse(lines[i]);
if (entry && entry.type === 'session' && entry.id) {
header = entry;
headerLine = i;
break;
}
} catch {}
}
if (!header) return null;

let sessionId = String(header.id);
if (!SAFE_PI_SESSION_ID.test(sessionId)) return null;
let projectPath = typeof header.cwd === 'string' ? header.cwd : '';
let title = typeof header.title === 'string' ? header.title.trim().slice(0, 200) : '';
if (!title) {
for (let i = 0; i < headerLine; i++) {
try {
const entry = JSON.parse(lines[i]);
if (entry && entry.type === 'title' && typeof entry.title === 'string' && entry.title.trim()) {
title = entry.title.trim().slice(0, 200);
break;
}
} catch {}
}
}
let msgCount = 0;
let userMsgCount = 0;
let firstMsg = '';
Expand All @@ -761,7 +782,7 @@ function parsePiSessionFile(sessionFile) {
let hasUsage = false;
let explicitCost = false;

for (let i = 1; i < lines.length; i++) {
for (let i = headerLine + 1; i < lines.length; i++) {
try {
const entry = JSON.parse(lines[i]);
const ts = parseTimestamp(entry.timestamp || entry.ts);
Expand Down
14 changes: 14 additions & 0 deletions test/pi-session.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,20 @@ test('parsePiSessionFile reads OMP header and message summary', () => {
assert.equal(summary.lastTs, Date.parse('2026-05-24T10:00:04.000Z'));
});

test('parsePiSessionFile reads title line before OMP session header', () => {
const dir = tmpDir();
const file = path.join(dir, 'sessions', '--tmp--project--', '2026-05-24T10-00-00.000Z_pi-session-title.jsonl');
writeJsonl(file, [
{ type: 'title', title: 'brief-improve' },
{ type: 'session', version: 3, id: 'pi-session-title', timestamp: '2026-05-24T10:00:00.000Z', cwd: '/tmp/project' },
{ type: 'message', timestamp: '2026-05-24T10:00:02.000Z', message: { role: 'user', content: [{ type: 'text', text: 'Please fix this' }] } },
]);

const summary = parsePiSessionFile(file);
assert.equal(summary.sessionId, 'pi-session-title');
assert.equal(summary.title, 'brief-improve');
});

test('parsePiSessionFile rejects unsafe header ids', () => {
const dir = tmpDir();
const file = path.join(dir, 'sessions', '--tmp--project--', 'bad.jsonl');
Expand Down
Loading