fix(isCreditCard): anchor Mastercard regex alternation#2727
Open
xxiaoxiong wants to merge 1 commit into
Open
Conversation
The Mastercard regex `/^5[1-5][0-9]{2}|(...)[0-9]{12}$/` has an
anchoring bug: `|` binds weaker than `^`/`$`, so `^` only anchors
the first branch (matching any 4-digit string starting with 51-55)
and `$` only anchors the second branch.
Wrapped in `(?:...)` so both anchors apply to all alternatives.
Also fixed the same issue in unionpay regex.
Fixes validatorjs#2717
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
isCreditCard("5108")returnstruebecause the Mastercard regex:has an anchoring bug:
|binds weaker than^and$, so the regex is parsed as:^5[1-5][0-9]{2}— start-anchored only, matches any 4+ digit string starting with 51-55(...)[0-9]{12}$— end-anchored onlyFix
Wrapped the alternation in a non-capturing group:
Also fixed the same issue in the unionpay regex.
Fixes #2717