fix(sheet): code block bg follows --card instead of theme-locked var#144
Merged
Conversation
The Tiptap code block wrapper (.code-block-body) painted a separate per- theme `--code-block-bg` (rose-pine, tokyo-night, monokai, etc.), while the .shiki layer inside already paints --card after PR #140. On short or empty code blocks the Shiki <pre> didn't fill the parent's full height so the leftover band leaked the theme-locked color through. Switch the wrapper to var(--card) so parent + child share one source of truth. --code-block-bg had this single reader, so its 16 per-theme declarations across index.css become dead code — deleted in the same pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sheet code blocks were still leaking the old per-theme bg color through. PR #140 pinned `.shiki` (the inner highlighted layer) to `var(--card)`, but the parent wrapper `.code-block-body` was still painting a separate per-theme variable `--code-block-bg` (rose-pine #191724, tokyo-night #1a1b26, monokai #272822, etc.). When the Shiki `
Test plan