Skip to content

add weak subjectivity logic#1569

Closed
paologalligit wants to merge 4 commits intomasterfrom
paolo/wsc
Closed

add weak subjectivity logic#1569
paologalligit wants to merge 4 commits intomasterfrom
paolo/wsc

Conversation

@paologalligit
Copy link
Copy Markdown
Member

Description

This PR introduces an optional flag --wsc-provider-url to allow the client to check against a week subjectivity checkpoint if the local synched chain is the canonical.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 72.00000% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/thor/node/wsc.go 81.25% 6 Missing and 6 partials ⚠️
cmd/thor/node/packer_loop.go 0.00% 5 Missing ⚠️
cmd/thor/main.go 0.00% 2 Missing ⚠️
cmd/thor/node/node.go 50.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@paologalligit paologalligit marked this pull request as ready for review February 6, 2026 11:07
@paologalligit paologalligit requested a review from a team as a code owner February 6, 2026 11:07
@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale PR/ Issue has been marked as stale label Apr 12, 2026
@github-actions github-actions bot closed this Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/ Issue has been marked as stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants