Skip to content

fix(logstash source): preserve writer windows when generating ACKs #25531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruceg merged 5 commits into from
Jun 1, 2026
Merged

fix(logstash source): preserve writer windows when generating ACKs #25531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b68bf9f
fix(logstash source): preserve writer windows when generating ACKs
bruceg May 29, 2026
fdabff3
Revert incomplete window handling regression
bruceg May 30, 2026
7cf29c3
Simplify logic in LogstashAcker::new
bruceg Jun 1, 2026
8a621b5
Add unit test for acking a partial window and assert all decoded sequ…
bruceg Jun 1, 2026
67ff5d4
Use a SmallVec for the acknowledgements
bruceg Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/25531_logstash_ack_windows.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fixed the `logstash` source to preserve writer window boundaries when generating ACKs. This prevents batched reads from producing ACK sequences that advance past the current window, which could lead to "invalid sequence number received" errors and duplicate retransmits under load.

authors: bruceg
Loading
Loading