-
Notifications
You must be signed in to change notification settings - Fork 85
Add support for copy action #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomaskraina
wants to merge
11
commits into
venmo:master
Choose a base branch
from
tomaskraina:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3d7607c
Add support for copy action
tomaskraina 8d7f22f
Merge commit '8a05589ea367f568542a536ad0bfe7d4731ddded'
tomaskraina f094557
Migrate to Swift 2.3
tomaskraina a0ab565
Update podspec to 1.2.0
tomaskraina aa0c12d
Fix wrong copy selectors
tomaskraina ca122b6
Version bump to 1.2.0.2
tomaskraina 3e4ed41
Migrate to Swift 3.0
tomaskraina 272c11b
Fix crashing bug when running UI tests in Simulator with iOS 10 and a…
tomaskraina dafc4d2
Merge branch 'master' of github.com:venmo/Static
tomaskraina c7a1281
Remove workaround to avoid crash as it’s no longer needed
tomaskraina 4605861
Use self sizing cells in example
tomaskraina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,9 @@ import UIKit | |
| /// Row or Accessory selection callback. | ||
| public typealias Selection = () -> Void | ||
|
|
||
| /// Row copy callback | ||
| public typealias CopyAction = (Row) -> Void | ||
|
|
||
| /// Representation of a table row. | ||
| public struct Row: Hashable, Equatable { | ||
|
|
||
|
|
@@ -113,7 +116,14 @@ public struct Row: Hashable, Equatable { | |
|
|
||
| /// Actions to show when swiping the cell, such as Delete. | ||
| public var editActions: [EditAction] | ||
|
|
||
| /// Action to run when the row is selected to copy | ||
| public var copyAction: CopyAction? | ||
|
|
||
| var canCopy: Bool { | ||
| return copyAction != nil | ||
| } | ||
|
|
||
| var canEdit: Bool { | ||
| return editActions.count > 0 | ||
| } | ||
|
|
@@ -134,7 +144,7 @@ public struct Row: Hashable, Equatable { | |
| // MARK: - Initializers | ||
|
|
||
| public init(text: String? = nil, detailText: String? = nil, selection: Selection? = nil, | ||
| image: UIImage? = nil, accessory: Accessory = .None, cellClass: CellType.Type? = nil, context: Context? = nil, editActions: [EditAction] = [], UUID: String = NSUUID().UUIDString) { | ||
| image: UIImage? = nil, accessory: Accessory = .None, cellClass: CellType.Type? = nil, context: Context? = nil, editActions: [EditAction] = [], copyAction: CopyAction? = nil, UUID: String = NSUUID().UUIDString) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you think about reverting this whitespace change at the beginning of the line? Agreed that this |
||
|
|
||
| self.UUID = UUID | ||
| self.text = text | ||
|
|
@@ -145,6 +155,7 @@ public struct Row: Hashable, Equatable { | |
| self.cellClass = cellClass ?? Value1Cell.self | ||
| self.context = context | ||
| self.editActions = editActions | ||
| self.copyAction = copyAction | ||
| } | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the rationale here for only supporting
#selector(NSObject.copy(_:)? Could we have supported other actions?