fix(realm): enforce exactly 4 realm extended measurements per spec#41
Open
shefali-kamal wants to merge 1 commit into
Open
fix(realm): enforce exactly 4 realm extended measurements per spec#41shefali-kamal wants to merge 1 commit into
shefali-kamal wants to merge 1 commit into
Conversation
The specification https://www.ietf.org/archive/id/draft-ffm-rats-cca-token-00.html#section-4.8.5 requires exactly 4 realm extensible measurements in the evidence. The previous implementatio only checked for non‑empty values, which allowed invalid inputs. ValidateExtendedMeas now returns ErrWrongSyntax if len(v) != MaxLenRealmExtendedMeas (4). Fixes: veraison#20 Signed-off-by: Badiyasar, Harshita <Harshita.Badiyasar@fujitsu.com>
setrofim
reviewed
May 27, 2026
| if len(v) == 0 { | ||
| return fmt.Errorf("%w realm extended measurements", | ||
| psatoken.ErrMandatoryClaimMissing) | ||
| if len(v) != MaxLenRealmExtendedMeas { |
Contributor
There was a problem hiding this comment.
MaxLenRealmExtendedMeas should probably be rename to just LenRealmExtendedMeas, as it is not a maximum but an exact value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification https://www.ietf.org/archive/id/draft-ffm-rats-cca-token-00.html#section-4.8.5 requires exactly 4 realm extensible measurements in the evidence. The previous implementatio only checked for non‑empty values, which allowed invalid inputs. ValidateExtendedMeas now returns ErrWrongSyntax if len(v) != MaxLenRealmExtendedMeas (4).
Fixes: #20