fix(json-collection): Use proper JSON Format for marshalling and unmarshalling.#5
Open
shefali-kamal wants to merge 3 commits into
Open
fix(json-collection): Use proper JSON Format for marshalling and unmarshalling.#5shefali-kamal wants to merge 3 commits into
shefali-kamal wants to merge 3 commits into
Conversation
Cargo.lock should be tracked by VCS. (https://blog.rust-lang.org/2023/08/29/committing-lockfiles/) Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
cmw::Collection::marshal_json converted the CMW values contained within into a string (after json serialization). This caused the json serialization of the CMW to have json strings as values, instead of json objects (in case of collection-cmws) or json records (in case of monad). Similarly, cmw::Collection::unmarshal_json expected the CMW values within it to be json strings instead of json objects or records. Now the marshal and unmarshal uses the proper json format. Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
Apply suggestion from clippy. Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes following:
fix(json-collection): Use proper JSON Format for marshalling and unmarshalling.
Also clean-up gitignore and track Cargo.lock
Fixes: #4