Attach the disallowed-dynamic reason to StaticGenBailoutError#95905
Open
yoshiki-maruya wants to merge 1 commit into
Open
Attach the disallowed-dynamic reason to StaticGenBailoutError#95905yoshiki-maruya wants to merge 1 commit into
yoshiki-maruya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In 9 locations in
packages/next/src/server/app-render/dynamic-rendering.tsandapp-render.tsx(includingthrowIfDisallowedDynamicandthrowIfSyncIOUsed),StaticGenBailoutErrorwas being thrown without a reason; this has been changed so that the reason that was already logged viaconsole.errorright before the throw is now attached as the error'smessage(and, where the original error object exists, as thecauseas well).Why?
When runtime ISR revalidation failed, only an
Errorwith an empty message was sent to error trackers viaonRequestError, making the failure impossible to diagnose.Side effects
The reason is now also displayed in the build output when a build fails (because the existing logic in the export worker prints
StaticGenBailoutErrormessages when present). The ~130 updated snapshots undertest/e2e/app-dir/cache-components-errorsreflect this new output.Testing
Added a new
dynamic-rendering.test.ts(confirmed to fail without the fix). Thecache-components-errorssuite has been updated and passes in all modes (dev/start × Turbopack/Webpack × with and without debug-prerender).Fixes #95867